Quote: add citation placeholder. #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mtias
commented
May 19, 2017
•
mtias
commented
mtias
added
[Feature] Blocks
youknowriad
approved these changes
May 19, 2017
There was a problem hiding this comment.
There's a small bug when we clear the citation input and focus the quote content area. The placeholder don't show up immediately, you have to unselece/select the block to make it appear.
This bug is not specific to this PR, but something that could appear with all placeholders.
👍 for this
|
I wonder if we should just do placeholders like this instead to simplify: isEmptyContent && notFocused
? <span onClick={ setFocus }>Placeholder text</span>
: <Editable />cc @iseulde in case you already explored that. |
|
@youknowriad It looks like selectionChange does not fire then. @mtias I have not. I'n not sure how we'd handle tabbing etc. then. |
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.